feat: Forward service traffic to hero_router instead of direct socket access #20

Merged

mahmoud merged 1 commit from development_router_forwarding into development

2026-04-09 12:33:29 +00:00

mahmoud commented

2026-04-09 10:06:54 +00:00

Owner

Summary

hero_proxy no longer does its own socket discovery. All service requests are forwarded to hero_router at localhost:9988.

Flow

Before: Network -> hero_proxy -> Unix sockets (direct)
After: Network -> hero_proxy -> hero_router:9988 -> Unix sockets

Changes

Replace socket lookup with forward_to_upstream() to hero_router
Remove dead code: extract_two_segment_prefix, not_found_page (~190 lines removed)
Add router_url to AppState (env: HERO_ROUTER_URL, default: http://127.0.0.1:9988)
Add create_app_state_with_router() for tests
Test harness spawns mock hero_router per test (no shared env var, no race conditions)

Test plan

cargo clippy --workspace --all-targets -- -D warnings passes
All tests pass (26 passed, 0 failed, run 3x for flakiness)
Live test: hero_proxy -> hero_router -> hero_compute on server

Closes #19

## Summary hero_proxy no longer does its own socket discovery. All service requests are forwarded to hero_router at localhost:9988. ## Flow **Before:** `Network -> hero_proxy -> Unix sockets (direct)` **After:** `Network -> hero_proxy -> hero_router:9988 -> Unix sockets` ## Changes - Replace socket lookup with `forward_to_upstream()` to hero_router - Remove dead code: `extract_two_segment_prefix`, `not_found_page` (~190 lines removed) - Add `router_url` to AppState (env: `HERO_ROUTER_URL`, default: `http://127.0.0.1:9988`) - Add `create_app_state_with_router()` for tests - Test harness spawns mock hero_router per test (no shared env var, no race conditions) ## Test plan - [x] `cargo clippy --workspace --all-targets -- -D warnings` passes - [x] All tests pass (26 passed, 0 failed, run 3x for flakiness) - [x] Live test: hero_proxy -> hero_router -> hero_compute on server Closes #19

mahmoud added 1 commit

2026-04-09 10:06:54 +00:00

feat: forward service traffic to hero_router instead of direct socket access

Test / test (push) Successful in 1m26s

Details

Test / test (pull_request) Successful in 1m24s

Details

8ad256ac2d

hero_proxy no longer does its own socket discovery and routing. All
service requests (/{service}/*) are forwarded to hero_router at
localhost:9988 (configurable via HERO_ROUTER_URL env var).

hero_router handles socket discovery, prefix stripping, and header
injection. hero_proxy handles network (Mycelium/TLS), auth, and
domain routing.

Flow: Network -> hero_proxy -> hero_router -> Unix sockets

- Replace socket lookup (find_socket_for, find_socket_by_name) with
  forward_to_upstream() call to hero_router
- Remove extract_two_segment_prefix and not_found_page (dead code)
- Add router_url to AppState (default: http://127.0.0.1:9988)
- Add create_app_state_with_router() for testing
- Update test harness with mock hero_router (TCP server that routes
  to mock backend sockets)

Closes #19