feat: Forward service traffic to hero_router instead of direct socket access #19

New issue

Closed

opened 2026-04-09 09:44:27 +00:00 by mahmoud · 0 comments

mahmoud commented

2026-04-09 09:44:27 +00:00

Owner

Problem

hero_proxy currently does its own socket discovery and forwards requests directly to Unix sockets. This bypasses hero_router, which is supposed to be the single component that talks to sockets (prefix stripping, header injection, service discovery).

Current flow

Request -> hero_proxy -> finds rpc.sock directly -> Unix socket

hero_router is not involved. If hero_router is stopped, hero_proxy still works.

Required flow

Network -> hero_proxy:9997 -> hero_router:9988 -> Unix sockets
Local   -> hero_router:9988 -> Unix sockets

hero_proxy handles: network (Mycelium/TLS), auth, domain routing.
hero_router handles: socket discovery, prefix stripping, header injection.

Implementation

Replace the path-based socket routing in proxy_handler with a single forward_to_upstream("http://127.0.0.1:9988", ...) call. The forward_to_upstream function already exists in domain.rs for domain-based TCP routing.

Changes in `proxy.rs`

Replace the socket lookup block (find_socket_by_name, find_socket_for, extract_two_segment_prefix, not_found_page) with:

// Forward all service requests to hero_router
forward_to_upstream(&state.router_url, None, req).await

The original URL path is preserved unchanged. hero_router handles prefix stripping and socket routing.

Changes in `config.rs`

Add router_url to config:

pub router_url: String,  // default: http://127.0.0.1:9988

Configurable via HERO_ROUTER_URL env var.

What stays

Domain-based routing (Host header -> DB routes) -- unchanged
Auth enforcement -- unchanged
TLS termination -- unchanged
Management API (OpenRPC) -- unchanged
Stopped endpoints -- kept (blocks before forwarding)
Socket scanning for list_services RPC -- kept

What gets removed from proxy_handler

find_socket_for() / find_socket_by_name() usage
extract_two_segment_prefix() routing logic
not_found_page() -- hero_router returns its own 404
Direct Unix socket forwarding via forward_axum()

hero_compute#83 -- multi-node connectivity depends on this
hero_sockets skill -- hero_router is the single TCP-to-UDS gateway

## Problem hero_proxy currently does its own socket discovery and forwards requests directly to Unix sockets. This bypasses hero_router, which is supposed to be the single component that talks to sockets (prefix stripping, header injection, service discovery). ## Current flow ``` Request -> hero_proxy -> finds rpc.sock directly -> Unix socket ``` hero_router is not involved. If hero_router is stopped, hero_proxy still works. ## Required flow ``` Network -> hero_proxy:9997 -> hero_router:9988 -> Unix sockets Local -> hero_router:9988 -> Unix sockets ``` hero_proxy handles: network (Mycelium/TLS), auth, domain routing. hero_router handles: socket discovery, prefix stripping, header injection. ## Implementation Replace the path-based socket routing in `proxy_handler` with a single `forward_to_upstream("http://127.0.0.1:9988", ...)` call. The `forward_to_upstream` function already exists in `domain.rs` for domain-based TCP routing. ### Changes in `proxy.rs` Replace the socket lookup block (find_socket_by_name, find_socket_for, extract_two_segment_prefix, not_found_page) with: ```rust // Forward all service requests to hero_router forward_to_upstream(&state.router_url, None, req).await ``` The original URL path is preserved unchanged. hero_router handles prefix stripping and socket routing. ### Changes in `config.rs` Add `router_url` to config: ```rust pub router_url: String, // default: http://127.0.0.1:9988 ``` Configurable via `HERO_ROUTER_URL` env var. ### What stays - Domain-based routing (Host header -> DB routes) -- unchanged - Auth enforcement -- unchanged - TLS termination -- unchanged - Management API (OpenRPC) -- unchanged - Stopped endpoints -- kept (blocks before forwarding) - Socket scanning for list_services RPC -- kept ### What gets removed from proxy_handler - find_socket_for() / find_socket_by_name() usage - extract_two_segment_prefix() routing logic - not_found_page() -- hero_router returns its own 404 - Direct Unix socket forwarding via forward_axum() ## Related - hero_compute#83 -- multi-node connectivity depends on this - hero_sockets skill -- hero_router is the single TCP-to-UDS gateway