lhumina_code/hero_rpc
21
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

feat: implement ADR 001 — configurable socket and data paths (Phase 1) #20

Open
delandtj wants to merge 1 commit from feat/parametrized-socket-path-optionality into development
pull from: feat/parametrized-socket-path-optionality
merge into: lhumina_code:development
Conversation 0 Commits 1 Files changed 13 +232 -135
delandtj commented 2026-04-08 15:34:52 +00:00
Member
Copy link

Add optional socket_dir/data_dir fields to OServerConfig with
builder methods and HERO_SOCKET_DIR/HERO_DATA_DIR env var fallback.
Convert static path helpers to instance methods and thread config
through OServer → DomainServer/CoreServer/Registry.

Resolution order: config field > env var > ~/hero/var/ default.
Zero breaking change for existing callers — defaults unchanged.

Add optional socket_dir/data_dir fields to OServerConfig with builder methods and HERO_SOCKET_DIR/HERO_DATA_DIR env var fallback. Convert static path helpers to instance methods and thread config through OServer → DomainServer/CoreServer/Registry. Resolution order: config field > env var > ~/hero/var/ default. Zero breaking change for existing callers — defaults unchanged.
Add optional socket_dir/data_dir fields to OServerConfig with
builder methods and HERO_SOCKET_DIR/HERO_DATA_DIR env var fallback.
Convert static path helpers to instance methods and thread config
through OServer → DomainServer/CoreServer/Registry.

Resolution order: config field > env var > ~/hero/var/ default.
Zero breaking change for existing callers — defaults unchanged.
delandtj force-pushed feat/parametrized-socket-path-optionality from 84851e923a to 7eba4fb291
Some checks failed
Test / test (pull_request) Failing after 40s
Details
2026-04-09 08:32:09 +00:00 Compare
delandtj force-pushed feat/parametrized-socket-path-optionality from 7eba4fb291
Some checks failed
Test / test (pull_request) Failing after 40s
Details
to 95a416f360
Some checks failed
Test / test (pull_request) Failing after 59s
Details
2026-04-09 08:36:10 +00:00 Compare
Some checks failed
Test / test (pull_request) Failing after 59s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/parametrized-socket-path-optionality:feat/parametrized-socket-path-optionality
git switch feat/parametrized-socket-path-optionality

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development
git merge --no-ff feat/parametrized-socket-path-optionality
git switch feat/parametrized-socket-path-optionality
git rebase development
git switch development
git merge --ff-only feat/parametrized-socket-path-optionality
git switch feat/parametrized-socket-path-optionality
git rebase development
git switch development
git merge --no-ff feat/parametrized-socket-path-optionality
git switch development
git merge --squash feat/parametrized-socket-path-optionality
git switch development
git merge --ff-only feat/parametrized-socket-path-optionality
git switch development
git merge feat/parametrized-socket-path-optionality
git push origin development
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_rpc!20
No description provided.