update: show node component versions in UI sidebar with hover details #81
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_compute!81
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "development_show_node_versions"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
/statusendpoint — no separate/versionroute~/hero/var/config.toml)Changes
crates/hero_compute_ui/Cargo.toml: Add toml dependency for config parsingcrates/hero_compute_ui/src/server.rs: Merge version data into detailed_health_handler, remove version_handlercrates/hero_compute_ui/static/js/dashboard.js:Populate version card from /status response, remove /version fetchcrates/hero_compute_ui/static/css/dashboard.css: Version hover card stylescrates/hero_compute_ui/templates/partials/sidebar.html: Version hover card markupTest plan
Resolves #76
Good job, I think it might be better if we used a UI card that displays on hover instead of using the element title property, for example, see the status on the navbar
@ -0,0 +1,1032 @@---This file should not be committed
@ -1,4 +1,17 @@fn main() {// Embed git hash at compile time so it works in production (no .git dir).let git_hash = std::process::Command::new("git")Let's use a better way, i would suggest that we remove the hash since we already have the release version
2bcb414af7785fbe3212As we now have the central config, i would recommend that we use it to get the versions, no need for the hash