lhumina_code/hero_planner
0
0
Fork 0
Code Issues 4 Pull requests Projects Releases 3 Packages Wiki Activity Actions

[hero_planner_server] system_counts returns conditions; clients expect necessary_conditions #26

New issue
Closed
opened 2026-06-14 16:25:21 +00:00 by sameh-farouk · 1 comment
sameh-farouk commented 2026-06-14 16:25:21 +00:00
Member
Copy link

system_counts returns a conditions field for necessary-condition counts, but the entity is necessary_condition everywhere else (the web UI reads necessary_conditions). The web remap aliases it. Minor, but the field name should match the entity for API/SDK consistency.

`system_counts` returns a `conditions` field for necessary-condition counts, but the entity is `necessary_condition` everywhere else (the web UI reads `necessary_conditions`). The web remap aliases it. Minor, but the field name should match the entity for API/SDK consistency.
sameh-farouk commented 2026-06-14 17:49:11 +00:00
Author
Member
Copy link

Fixed on development in 7976504 — renamed EntityCounts.conditions → necessary_conditions in the .oschema + the system_counts impl (the entity is necessary_condition everywhere else; the web reads necessary_conditions).

Verified: system_counts(main) returns necessary_conditions: 3 (a real SQL COUNT(*)), no stale conditions key; the regenerated openrpc_main.json reflects it. Source-only.

Fixed on `development` in `7976504` — renamed `EntityCounts.conditions` → `necessary_conditions` in the `.oschema` + the `system_counts` impl (the entity is `necessary_condition` everywhere else; the web reads `necessary_conditions`). Verified: `system_counts(main)` returns `necessary_conditions: 3` (a real SQL `COUNT(*)`), no stale `conditions` key; the regenerated `openrpc_main.json` reflects it. Source-only.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
development
integration
development_sameh
development_freeze
development_sameh_main_tagname
development_sameh_ci_release_tag
latest-development
latest-integration
latest-main
latest
latest-dev
v0.1.0-rc2
v0.1.0-rc1
Labels
Clear labels   
area:admin

Admin dashboard (hero_planner_admin)

  
area:backend

Server / RPC / store (hero_planner_server/lib)

  
area:web-ui

End-user web app (hero_planner_web)

  
bug

Something is broken or behaves incorrectly

  
enhancement

Improvement to existing functionality

  
feature-request

A new capability that does not exist yet

  
good-first-issue

Small, self-contained, clear fix

  
ux

Usability / discoverability

No labels
area:admin
area:backend
area:web-ui
bug
enhancement
feature-request
good-first-issue
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
sameh-farouk
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_planner#26
No description provided.