Models Don't Auto-download on `embedderd --start` #2

New issue

Closed

opened 2026-01-27 14:54:00 +00:00 by rawan · 2 comments

rawan commented

2026-01-27 14:54:00 +00:00

Member

Current behaviour:

embedderd checks if the models directory exists, if not it fails with this error

✗ Service 'embedderd' failed

Recent logs:
  Run ./download_models.sh first
  Error: Models directory not found: /home/rawan/hero/var/embedder/models
  
  ========================================
    HeroEmbedder - Loading all models...
  ========================================

Expected behavior:

Models are auto-downloaded if they don't exist
Models download shouldn't timeout to download the models
Models should download in background, we should be able to test this with openrpc endpoint

## Current behaviour: - embedderd checks if the models directory exists, if not it fails with this error ``` ✗ Service 'embedderd' failed Recent logs: Run ./download_models.sh first Error: Models directory not found: /home/rawan/hero/var/embedder/models ======================================== HeroEmbedder - Loading all models... ======================================== ``` ## Expected behavior: - Models are auto-downloaded if they don't exist - Models download shouldn't timeout to download the models - Models should download in background, we should be able to test this with openrpc endpoint

rawan referenced this issue

2026-01-27 15:01:16 +00:00

test the embedding start #1

salmaelsoly commented

2026-01-28 14:34:24 +00:00

Member

Models are auto downloaded if they doesn't exist
Models download doesn't timeout
Models are downloaded in the foreground process for now, when it was added as a background process two issues appeared:
* Race condition: between the thread downloading the model (writing in the directory) and zinit service trying to read from this directory
* Partial download problem: when download happens in the background it partially downloads the models while the server expects that all models are downloaded in the directory, so in that case the server have the possibility to use a non-existent model while it should not
@rawan

- [x] Models are auto downloaded if they doesn't exist - [x] Models download doesn't timeout - Models are downloaded in the foreground process for now, when it was added as a background process two issues appeared: * **Race condition:** between the thread downloading the model (writing in the directory) and zinit service trying to read from this directory * **Partial download problem:** when download happens in the background it partially downloads the models while the server expects that all models are downloaded in the directory, so in that case the server have the possibility to use a non-existent model while it should not @rawan

rawan referenced this issue

2026-01-28 14:37:36 +00:00

Auto-download Models on embedderd --start #3